Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add onnx op fields and remove OpBuildTable.inc #2249

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/BuildONNX.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

# Installing `third_party ONNX` for Backend Tests or Rebuilding ONNX Operations

Backend tests are triggered by `make check-onnx-backend` in the build directory and require a few preliminary steps to run successfully. Similarly, rebuilding the ONNX operations in ONNX-MLIR from their ONNX descriptions is triggered by `make OMONNXOpsIncTranslation`.
Backend tests are triggered by `make check-onnx-backend` in the build directory and require a few preliminary steps to run successfully. Similarly, rebuilding the ONNX operations in ONNX-MLIR from their ONNX descriptions is triggered by `make OMONNXOpsTableGenIncGen`.

You will need to install python 3.x if its not default in your environment, and possibly set the cmake `PYTHON_EXECUTABLE` variable in your top cmake file.

Expand All @@ -24,7 +24,7 @@ Here are the steps taken to upgrade the ONNX version:

6. Build onnx in the `build/` directory using: set CMAKE_ARGS=-DONNX_USE_LITE_PROTO=ON

7. Run in the `build/` directory : make OMONNXOpsIncTranslation
7. Run in the `build/` directory : make OMONNXOpsTableGenIncGen

8. Run in `build/` directory : make onnx-mlir-docs

Expand Down
2 changes: 1 addition & 1 deletion docs/ImportONNXDefs.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ the code in the dictionary `custom_definition_misc`. The key is the operation na
In order to run gen_onnx_mlir.py, ONNX has to be installed. Refer to Readme.
In your build directory, execute the following command.
```
make OMONNXOpsIncTranslation
make OMONNXOpsTableGenIncGen
```
This command will generate those two files (src/Dialect/ONNX/ONNXOps.td.inc and
OpBuilderTable.inc), and copy them to the right place in src directory.
Expand Down
5 changes: 0 additions & 5 deletions src/Builder/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,3 @@ add_onnx_mlir_library(OMBuilder
MLIRFuncDialect
onnx
)

configure_file(OpBuildTable.inc.dc.in
${CMAKE_CURRENT_BINARY_DIR}/OpBuildTable.inc.dc
@ONLY
)
Loading