Skip to content

Conversation

justinchuby
Copy link
Member

@justinchuby justinchuby commented Oct 1, 2025

Do not modify the value name if the new name is invalid. This makes the setter of Value.name safer in that things will not be left in an inconsistent state if a check fails

Do not modify the value name if the new name is invalid

Signed-off-by: Justin Chu <[email protected]>
@justinchuby justinchuby requested review from titaiwangms and a team as code owners October 1, 2025 21:37
Signed-off-by: Justin Chu <[email protected]>
@justinchuby justinchuby added this to the 0.1.11 milestone Oct 1, 2025
Signed-off-by: Justin Chu <[email protected]>
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.81%. Comparing base (49a361c) to head (9914dcc).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
+ Coverage   76.80%   76.81%   +0.01%     
==========================================
  Files          40       40              
  Lines        4915     4922       +7     
  Branches      978      980       +2     
==========================================
+ Hits         3775     3781       +6     
  Misses        856      856              
- Partials      284      285       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby merged commit f0fcffb into main Oct 3, 2025
23 checks passed
@justinchuby justinchuby deleted the justinchu/safe-name branch October 3, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants