[Resolves] Support ingesting a digest model report/cache #3
Conversation
- Offers solution for steps 1-3
- added steps 4-6
- robust pixmap handling - better pixmap quality - copy png instead of grab() - scale loading gif - multimodel report support - recompiled gui with pyside6.8.1
- various quality updates to gui
|
TODO: add a check for duplicate YAML reports in the multi model analysis tool. Done in commit 03af35c |
| @@ -1,17 +1,22 @@ | |||
| # Copyright(C) 2024 Advanced Micro Devices, Inc. All rights reserved. | |||
|
|
|||
| """Unit tests for Vitis ONNX Model Analyzer """ | |||
|
|
|||
| import os | |||
There was a problem hiding this comment.
Any thoughts on adding those reports as workflows in the future so this can run on CI?
| Report created on June 02, 2024 | ||
| ONNX file: resnet18.onnx | ||
| Report created on December 06, 2024 | ||
| ONNX file: C:\Users\pcolange\Projects\digestai\test\resnet18.onnx |
There was a problem hiding this comment.
Looks like your personal paths are getting into the code here. Is that intended/avoidable?
| @@ -81,7 +81,6 @@ enable = | |||
| expression-not-assigned, | |||
There was a problem hiding this comment.
Would be nice to add some documentation on this new feature. I don't see any.
| huggingface: true |
| def parse_model_nodes(self) -> None: | ||
| """There are no model nodes to parse""" | ||
|
|
||
| def save_yaml_report(self, filepath: str) -> None: | ||
| """Report models are not intended to be saved""" | ||
|
|
||
| def save_text_report(self, filepath: str) -> None: | ||
| """Report models are not intended to be saved""" |
There was a problem hiding this comment.
A bit weird to see those here without a "pass", but I guess the docstrings work
| # print("Differences found:") | ||
| # for diff in differences: | ||
| # print(f"- {diff}") |
There was a problem hiding this comment.
| # print("Differences found:") | |
| # for diff in differences: | |
| # print(f"- {diff}") |
| # print(f"- {diff}") | ||
| return False | ||
| else: | ||
| # print("No differences found.") |
There was a problem hiding this comment.
| # print("No differences found.") |
| print( | ||
| "Found the following non-static input dims in your model. " | ||
| "It is recommended to make all dims static before generating reports." | ||
| ) |
There was a problem hiding this comment.
Most users will never see this as this is printed to the terminal instead of showing up in the GUI. Is that ok?
Closes #2