fix(computer-use): scale scroll amounts #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthewjmarangoni I like this approach! Would you mind updating the Python version with the same logic? |
|
Can do. |
matthewjmarangoni
changed the title
|
The Python template has been updated and both templates outputs changed to show pixels instead of percentages. Ready for review @juecd! |
|
@jaskirat05 will take a look here, thanks Jas! |
juecd
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an approach fixing the TypeScript Computer Use template application scrolling too little (fixes Issue #20).
This method determines the dimensions of the screen available to the browser page, partitioning it, and using that as a scaling factor for the step amounts provided by Claude. It is intended to handle screen resolution and window size changes without enforcing a restriction on the maximum scroll amount.
A drawback of unbounded scaling is it could result in extreme jumps if at some point Claude generates actual pixel values.
This PR does not cover the Python template. It appears to already use a constant scaling factor but could be adapted if this approach is accepted.