Skip to content

Conversation

@masnwilliams
Copy link
Contributor

No description provided.

@mesa-dot-dev
Copy link

mesa-dot-dev bot commented Nov 30, 2025

Mesa Description

This pull request refactors the CLI to remove the concept of persistent-id from browser commands, simplifying the user interface and promoting a more robust approach to session management. The --by-persistent-id and --by-id flags have been removed, and users will now refer to browsers simply by their <id>. For creating persistent browser sessions, the --persistent-id flag for browsers create has been deprecated, with guidance to use --timeout and --profile-name instead. The README.md has been updated to reflect these changes and provide new examples.

Description generated by Mesa. Update settings

Copy link

@mesa-dot-dev mesa-dot-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed full review of cfa1f71...b0b666b

Analysis

While the PR introduces a clean deprecation of 'persistent-id' with good practices, potential architectural issues include:

  1. The deprecation of 'persistent-id' in favor of timeout and profiles may introduce a conceptual shift in resource lifecycle management that could confuse long-time users who relied on name-based persistence.

  2. The PR does not appear to address migration tooling to help users automatically convert existing scripts from persistent-id patterns to the new timeout/profile paradigm.

  3. A 72-hour timeout maximum might be insufficient for some long-running workflows that previously relied on indefinite persistence through IDs.

  4. The PR focuses on CLI changes without mentioning potential impacts to programmatic API consumers who may have integrated with the persistent-id concept.

Tip

Help

Slash Commands:

  • /review - Request a full code review
  • /review latest - Review only changes since the last review
  • /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
  • /help - Get help with Mesa commands and configuration options

2 files reviewed | 0 comments | Edit Agent SettingsRead Docs

Copy link
Contributor

@dprevoznik dprevoznik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change requested

Copy link
Contributor

@dprevoznik dprevoznik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masnwilliams masnwilliams merged commit 5d277a1 into main Dec 1, 2025
2 checks passed
@masnwilliams masnwilliams deleted the mason/browser-persist-depcrecate branch December 1, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants