Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying to add the command to scroll the hover popup, but i am stuck at how should i update
HoverView
, first i thought about exposing aHoverView.update
function, but then how would i know the current value? Since the scroll is basically increase and decrease that value, in my mind the process is: Check if there is some active session, if so get thescrollTop
value and update it depending on the command. My question is where should i expose thescrollTop
value?Please tell if there is something wrong in my logic