Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache EventEmitter instances based on event names #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Cache EventEmitter instances based on event names #4

wants to merge 2 commits into from

Conversation

GeorgeTG
Copy link

To fix oni #2323
Should only be merged if oni #2355 is merged.
This change will brake oni without that PR (will also break all previous versions, maybe some version restrictions should be applied on both).

@akinsho
Copy link
Member

akinsho commented Jun 26, 2018

@GeorgeTG thanks for the PR looks good to me, although we will need @bryphe to take a look as a change here will require the package version to be bumped and published to npm to use in oni-core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple instances of Event class for the same event cause events being missed
2 participants
@GeorgeTG @akinsho