Skip to content

[Access] Changed max subscription error code to 429 #7158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2025

Conversation

Guitarheroua
Copy link
Contributor

@Guitarheroua Guitarheroua commented Mar 14, 2025

In this PR the error code for max subscriptions reached was changed from 503 to 429, as this is not a server error, but more server limitation.

See context here

Closes #7177

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.25%. Comparing base (1739d1d) to head (7b679d3).

Files with missing lines Patch % Lines
engine/access/rest/websockets/controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7158      +/-   ##
==========================================
- Coverage   41.25%   41.25%   -0.01%     
==========================================
  Files        2170     2170              
  Lines      190109   190109              
==========================================
- Hits        78435    78431       -4     
- Misses     105128   105131       +3     
- Partials     6546     6547       +1     
Flag Coverage Δ
unittests 41.25% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a test case that covers this? If not we should add one.

@illia-malachyn
Copy link
Contributor

is there a test case that covers this? If not we should add one.

Yes, there is. I updated the PR

@illia-malachyn
Copy link
Contributor

@peterargue I added this to the board (even though it is a PR) because I guess we forgot about this one

@illia-malachyn
Copy link
Contributor

Created a separate issue for this

@peterargue peterargue added this pull request to the merge queue Mar 24, 2025
Merged via the queue into master with commit 6946bd2 Mar 24, 2025
56 checks passed
@peterargue peterargue deleted the AndriiSlisarchuk/6644-bugfix-change-error-code branch March 24, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Change max subscription error code
4 participants