-
Notifications
You must be signed in to change notification settings - Fork 195
[Access] Changed max subscription error code to 429 #7158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Changed max subscription error code to 429 #7158
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7158 +/- ##
==========================================
- Coverage 41.25% 41.25% -0.01%
==========================================
Files 2170 2170
Lines 190109 190109
==========================================
- Hits 78435 78431 -4
- Misses 105128 105131 +3
- Partials 6546 6547 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a test case that covers this? If not we should add one.
Yes, there is. I updated the PR |
@peterargue I added this to the board (even though it is a PR) because I guess we forgot about this one |
Created a separate issue for this |
In this PR the error code for max subscriptions reached was changed from 503 to 429, as this is not a server error, but more server limitation.
See context here
Closes #7177