Add new websocket handler and skeleton for its deps #6630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added websocket controller * Added mock block provider * Added data provider factory * Added websocket handler * Added websocket config * Added a tiny POC test for websocket handler
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6630 +/- ##
==========================================
- Coverage 41.23% 41.08% -0.16%
==========================================
Files 2054 2022 -32
Lines 182364 178761 -3603
==========================================
- Hits 75204 73439 -1765
+ Misses 100859 99179 -1680
+ Partials 6301 6143 -158
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
Speaking of tests, I see it the following way: we should write a wrap websocket connection with our custom mock and write unit tests for websocket controller (it accepts ws conn as argument). This will require some code, so a separate task should be created for this #6631 |
illia-malachyn
commented
Nov 8, 2024
peterargue
reviewed
Nov 9, 2024
jribbink
reviewed
Nov 9, 2024
* Use contexts as function arguments * Move models to folder for consistency * Change parse msg function * Simplify mock block provider to remove dedlock
peterargue
reviewed
Nov 12, 2024
* make handle_connection blocking * rename concurrent_map * use type switch instead of switch * add todos for error handling
| dp.Close() | ||
| c.dataProviders.Remove(id) | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| //TODO: return OK response to client | |
| } |
Guitarheroua
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6593 #6583 #6617
Relates to #6584