Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Time To Seal metric to access node to track time it takes to seal a transaction #6512

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

AndriiDiachuk
Copy link
Contributor

Closes: #6448.

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 63 lines in your changes missing coverage. Please review.

Project coverage is 41.11%. Comparing base (21cfe5a) to head (41b0fad).

Files with missing lines Patch % Lines
module/metrics/transaction.go 0.00% 36 Missing ⚠️
...chronization/indexer/collection_executed_metric.go 0.00% 10 Missing ⚠️
cmd/access/node_builder/access_node_builder.go 0.00% 6 Missing ⚠️
cmd/observer/node_builder/observer_builder.go 0.00% 6 Missing ⚠️
module/mock/access_metrics.go 0.00% 2 Missing ⚠️
module/mock/transaction_metrics.go 0.00% 2 Missing ⚠️
module/metrics/noop.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6512      +/-   ##
==========================================
- Coverage   41.28%   41.11%   -0.18%     
==========================================
  Files        2030     1912     -118     
  Lines      145865   135951    -9914     
==========================================
- Hits        60221    55894    -4327     
+ Misses      79419    74385    -5034     
+ Partials     6225     5672     -553     
Flag Coverage Δ
unittests 41.11% <0.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Time To Seal metric to access node to track time it takes to seal a transaction
2 participants