[Execution] Remove deprecated ingestion engine #6510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6510 +/- ##
==========================================
- Coverage 41.28% 41.16% -0.13%
==========================================
Files 2030 2028 -2
Lines 145837 145369 -468
==========================================
- Hits 60213 59844 -369
+ Misses 79397 79345 -52
+ Partials 6227 6180 -47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhangchiqing
force-pushed
the
leo/remove-unused-ingestion-and-metrics
branch
from
ada0901
to
26edb83
Compare
zhangchiqing
force-pushed
the
leo/remove-unused-ingestion-and-metrics
branch
from
26edb83
to
51b9301
Compare
zhangchiqing
requested review from
peterargue and
janezpodhostnik
and removed request for
ramtinms
peterargue
approved these changes
Oct 2, 2024
Co-authored-by: Peter Argue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new execution ingestion engine has been enabled by default. It's been running for over 4 months now since May (v0.33.27) on mainnet EN1 and EN2. The old ingestion engine has been deprecated, and can now be removed.
This PR removes the deprecated execution ingestion engine. It fixes a few test cases that were using the deprecated ingestion engine to use the new ingestion engine. No logic changes.