Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EFM] Update DKG engine to submit a valid DKG index map #6490

Open
wants to merge 12 commits into
base: feature/efm-recovery
Choose a base branch
from

Conversation

durkmurder
Copy link
Member

@durkmurder durkmurder commented Sep 23, 2024

#6319

Context

This PR modifies the existing logic to construct and submit DKG Index Map for each participant. Updated DKG reactor engine, client, broker. Since smart contracts were changed as well, this PR updates how we interact with he on chain logic using new API.
Specifically:

  • successful DKG and failure are submitted using different endpoints
  • added support for updated method signature of successful DKG API call

Updated test suites and DKG emulator integration tests.

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 4.49438% with 85 lines in your changes missing coverage. Please review.

Project coverage is 42.18%. Comparing base (57a10de) to head (39574e7).

Files with missing lines Patch % Lines
module/dkg/client.go 0.00% 52 Missing ⚠️
module/mock/dkg_contract_client.go 0.00% 14 Missing ⚠️
module/dkg/broker.go 25.00% 12 Missing ⚠️
module/dkg/controller_factory.go 0.00% 5 Missing ⚠️
utils/unittest/execution_state.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##           feature/efm-recovery    #6490      +/-   ##
========================================================
+ Coverage                 41.43%   42.18%   +0.75%     
========================================================
  Files                      2029     1888     -141     
  Lines                    144665   133888   -10777     
========================================================
- Hits                      59941    56487    -3454     
+ Misses                    78541    71546    -6995     
+ Partials                   6183     5855     -328     
Flag Coverage Δ
unittests 42.18% <4.49%> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

module/dkg/broker.go Outdated Show resolved Hide resolved
module/dkg/broker.go Outdated Show resolved Hide resolved
module/dkg/broker.go Show resolved Hide resolved
module/dkg/broker.go Outdated Show resolved Hide resolved
module/dkg/broker.go Outdated Show resolved Hide resolved
module/dkg.go Outdated Show resolved Hide resolved
module/dkg.go Outdated Show resolved Hide resolved
module/dkg/client.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants