Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return json object on /scripts endpoint as documented in OpenAPI #6412

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

illia-malachyn
Copy link
Contributor

@illia-malachyn illia-malachyn commented Aug 28, 2024

Work on #2601

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.32%. Comparing base (ca70376) to head (5b0019c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6412      +/-   ##
==========================================
- Coverage   41.46%   41.32%   -0.15%     
==========================================
  Files        2016     1898     -118     
  Lines      143726   133790    -9936     
==========================================
- Hits        59595    55287    -4308     
+ Misses      77954    72881    -5073     
+ Partials     6177     5622     -555     
Flag Coverage Δ
unittests 41.32% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@illia-malachyn illia-malachyn marked this pull request as draft August 28, 2024 14:00
@illia-malachyn
Copy link
Contributor Author

illia-malachyn commented Aug 28, 2024

TODO:
test for error need to be fixed;
update openapi schema with base64 format for scriptBody.args;
figure out why one test path fails;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants