Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Use Indexed height when checking payer balance #6292

Conversation

AndriiDiachuk
Copy link
Contributor

@AndriiDiachuk AndriiDiachuk commented Aug 1, 2024

In this PR was changed block height for checking payer balance. Instead of using the latest sealed block, was used the latest indexed block.

Related PR: onflow/flow-emulator#724

Closes: #6129

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 25.53191% with 35 lines in your changes missing coverage. Please review.

Project coverage is 41.27%. Comparing base (7d782c8) to head (0a7f162).

Files with missing lines Patch % Lines
access/mock/blocks.go 0.00% 17 Missing ⚠️
access/validator.go 37.50% 9 Missing and 1 partial ⚠️
cmd/access/node_builder/access_node_builder.go 0.00% 4 Missing ⚠️
cmd/observer/node_builder/observer_builder.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6292      +/-   ##
==========================================
- Coverage   41.28%   41.27%   -0.02%     
==========================================
  Files        2030     2030              
  Lines      145837   145865      +28     
==========================================
- Hits        60213    60202      -11     
- Misses      79397    79437      +40     
+ Partials     6227     6226       -1     
Flag Coverage Δ
unittests 41.27% <25.53%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndriiDiachuk AndriiDiachuk marked this pull request as ready for review August 7, 2024 12:55
access/errors.go Outdated Show resolved Hide resolved
access/errors.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@Guitarheroua Guitarheroua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just has a couple of minor comments.

access/validator.go Outdated Show resolved Hide resolved
access/validator.go Outdated Show resolved Hide resolved
access/validator.go Outdated Show resolved Hide resolved
access/validator.go Show resolved Hide resolved
access/validator.go Show resolved Hide resolved
access/validator.go Show resolved Hide resolved
Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a suggestion for phrasing one of the comments. otherwise this looks good

access/validator.go Outdated Show resolved Hide resolved
@peterargue
Copy link
Contributor

@AndriiDiachuk please fix conflicts

@peterargue
Copy link
Contributor

@AndriiDiachuk looks like there's some more conflicts to fix. can you take a look

integration/go.mod Outdated Show resolved Hide resolved
@peterargue peterargue added this pull request to the merge queue Oct 2, 2024
Merged via the queue into onflow:master with commit 21cfe5a Oct 2, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Use Indexed height when checking payer balance
4 participants