-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BFT] Add Staking Key PoP to bootstrapping tools #2803
Draft
tarakby
wants to merge
15
commits into
master
Choose a base branch
from
tarak/6286-spork-tool-pop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarakby
changed the title
Tarak/6286 spork tool pop
[BFT] Add Staking Key PoP to bootstrapping tools.
Jul 14, 2022
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2803 +/- ##
==========================================
+ Coverage 55.49% 55.59% +0.09%
==========================================
Files 1133 1134 +1
Lines 89496 89711 +215
==========================================
+ Hits 49662 49871 +209
+ Misses 35062 35044 -18
- Partials 4772 4796 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tarakby
changed the title
[BFT] Add Staking Key PoP to bootstrapping tools.
[BFT] Add Staking Key PoP to bootstrapping tools
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/dapperlabs/flow-go/issues/6286
PoP refers to the Proof of Possession of the staking private key. Requiring a PoP is necessary to secure BLS aggregation and SPoCK in the protocol.
This PR includes PoP generation/validation in the bootstrapping command tool: