Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compiler] Generalize arithmetic instructions for all number values #3761

Open
wants to merge 1 commit into
base: feature/compiler
Choose a base branch
from
Open

[Compiler] Generalize arithmetic instructions for all number values #3761

wants to merge 1 commit into from

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Feb 5, 2025 •
edited
Loading

Work towards #3742

Description

As discussed in #3742 (comment), generalize the existing arithmetic and comparison instructions for all number values.

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from jsproz February 5, 2025 23:22
@turbolent turbolent self-assigned this Feb 5, 2025
@turbolent turbolent requested a review from SupunS as a code owner February 5, 2025 23:22
@turbolent turbolent force-pushed the bastian/improve-comparison-and-arithmetic-instructions branch from b1146ba to 64ee22b Compare February 5, 2025 23:23
Base automatically changed from bastian/document-stack-effects-in-comments to feature/compiler February 5, 2025 23:24
@turbolent turbolent closed this Feb 5, 2025
@turbolent turbolent reopened this Feb 5, 2025
@turbolent turbolent changed the title [Compiler] Ggeneralize arithmetic instructions for all number values [Compiler] Generalize arithmetic instructions for all number values Feb 5, 2025
turbolent
turbolent commented Feb 5, 2025
View reviewed changes
bbq/opcode/instructions.yml
@@ -1,3 +1,4 @@
# $schema: ./gen/instructions.schema.json
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://www.jetbrains.com/help/idea/yaml.html#use-schema-keyword

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/compiler commit 6443aa9
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsproz jsproz Awaiting requested review from jsproz

@SupunS SupunS Awaiting requested review from SupunS SupunS is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@turbolent turbolent

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@turbolent