Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address latest comments on PR #3760

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

address latest comments on PR #3760

wants to merge 1 commit into from

Conversation

jsproz
Copy link
Contributor

@jsproz jsproz commented Feb 5, 2025

Closes #3686

Continuation of PR #3707

PR #3707 auto merged before last commit was pushed.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link

github-actions bot commented Feb 5, 2025

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 0df2af0
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent
Copy link
Member

Please also add a label when checking off "Added appropriate labels"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Machine Readable Syntax Specification
2 participants