Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle command failures in update tool #3749

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

turbolent
Copy link
Member

Description

It turns out that exec does not fail (reject the promise) when the command exits with a bad exit code.
Make command execution strict


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from jsproz January 30, 2025 19:54
@turbolent turbolent self-assigned this Jan 30, 2025
@turbolent turbolent requested a review from SupunS as a code owner January 30, 2025 19:54
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 68a0460
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant