Replace COA.call with COA.callWithSigAndArgs for reduced computation cost

[m-Peter]

Related: onflow/flow-go#8401
Closes: #149

Description

Previously, to perform contract calls using a COA, it was necessary to produce the callData on Cadence side:

let calldata = EVM.encodeABIWithSignature(signature, args)

To be able to ABI-decode the returned data from the COA call, another step was needed:

let decoded = EVM.decodeABI(types: [Type<[UInt256]>()], data: res.data)
let amountsOut = decoded[0] as! [UInt256]

After doing some profiling on Cadence transactions, the computation cost of ABI encoding/decoding, amounted to about 15%-20% of the total computation, which is not trivial.

To optimize this case, we have a new wrapper function, callWithSigAndArgs, which does all this more efficiently:

coa.callWithSigAndArgs(
    to: to,
    signature: "approve(address,uint256)",
    args: [self.routerAddress, evmAmountIn],
    gasLimit: gasLimit,
    value: valueBalance.attoflow,
    resultTypes: [Type<[UInt256]>()]
)

We do the same for dryCall, by replacing it with dryCallWithSigAndArgs .

NOTE: CI is failing because we still need to deploy the EVM system contract on testnet/mainnet, for these new functions to be available.

[m-Peter]

fee is of type UInt32, not sure why it is being casted to UInt256.

The Solidity function expects a uint24, as can be seen from the signature: getPool(address,address,uint24). Cadence doesn't have an equivalent of UInt24, but I suppose that a UInt32 would work just fine.

[m-Peter]

It is more efficient to use the ABI-decoded result from coa.dryCallWithSigAndArgs, than to do word manipulation in Cadence, on-chain.

[m-Peter]

UInt should be large enough to hold a uint160 Solidity value.
Int32 should also be large enough to hold a int24 Solidity value.

[m-Peter]

It is more efficient to use the ABI-decoded result from coa.dryCallWithSigAndArgs, than to do word manipulation in Cadence, on-chain.

[joshuahannan]

Looks okay to me, but I'm not very familiar with these contracts, so someone else should give a review too