[WIP] Update the commonly used functions to use Fabric instead of Fabric3 #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def prompt(text, default=None, validate=None): | ||
| if default: | ||
| text = text.strip() | ||
| if text[-1] == ':' and len(text) > 1: |
Contributor
There was a problem hiding this comment.
As this function is only used internally, I'm not sure why you would strip a colon from the end if it is present - just don't use the function that way.
| def title_print(title, state=''): | ||
| def prompt(text, default=None, validate=None): | ||
| if default: | ||
| text = text.strip() |
Contributor
There was a problem hiding this comment.
Similar to my below comment - as it's used internally only, just don't call it with whitespace on the end..
Also remove bitbucket support to simplify branches significantly
lewiscollard
suggested changes
Jul 31, 2019
| with virtualenv(new_venv), shell_env(DJANGO_SETTINGS_MODULE=settings_module): | ||
| sudo('[[ -e requirements.txt ]] && pip install -r requirements.txt') | ||
| sudo('pip install gunicorn') | ||
| with connection.prefix(f'workon {new_venv}'): |
Contributor
There was a problem hiding this comment.
Don't assume virtualenvwrapper is installed, which provides workon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fabric3 is dead since as of version 2, fabric supports python 3. fabric3 uses pycrypto which is itself an old a dead package. I'd rather not use an out of date cryptography package if we can avoid it.
This does mean we have to change how all the commands work however as the syntax for fabric 2.0 is wildly different to fabric 1.0 which is what the syntax for fabric3 was based on.
All commands updated, commands tested: