Frontend editing #158
Open
Frontend editing #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
lewiscollard
suggested changes
Dec 18, 2018
| event.preventDefault() | ||
|
|
||
| // Inform the parent page of the selected item | ||
| window.parent.postMessage(pk, '*'); |
Contributor
There was a problem hiding this comment.
* should not be used in this case. From MDN:
Always provide a specific targetOrigin, not *, if you know where the other window's document should be located. Failing to provide a specific target discloses the data you send to any interested malicious site.
In this case it should always be the same origin - use window.location.origin instead.
| pk = pk.split('/') | ||
| pk = pk[4] | ||
|
|
||
| // Prevent default |
Contributor
There was a problem hiding this comment.
This comment doesn't add any information - we know what event.preventDefault does, and "Prevent default" wouldn't explain it to anyone if they did not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes needed for PR#302 on PT