Skip to content

Commit

Permalink
Released 1.21.0.
Browse files Browse the repository at this point in the history
  • Loading branch information
bsutton committed Oct 16, 2022
1 parent 6f6caff commit f3fd159
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 30 deletions.
4 changes: 4 additions & 0 deletions dcli/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# 1.21.0
- Upgraded to scope 3.0. Fixed a bug in withEnvironment as we need two version, a sync and async version.


# 1.20.3
- Fixed a bug in DCliZone.run. If you passed a Progress.capture to the run method the capture would be empty. Added a call to waitForEx to give the progress listeners a chance to run.
- Back ported changes to verbose so that it reports the file and line number of each verbose statement.
Expand Down
5 changes: 1 addition & 4 deletions dcli/lib/src/functions/ask.dart
Original file line number Diff line number Diff line change
Expand Up @@ -262,10 +262,7 @@ class Ask extends core.DCliFunction {
// print a space an move back again.
// required to clear the current character
// move back one space.
stdout
..writeCharCode(_)
..writeCharCode(_space)
..writeCharCode(_);
stdout..writeCharCode(_)..writeCharCode(_space)..writeCharCode(_);
value.removeLast();
}
} else {
Expand Down
17 changes: 4 additions & 13 deletions dcli/lib/src/platform/windows/registry.dart
Original file line number Diff line number Diff line change
Expand Up @@ -434,10 +434,7 @@ _RegResults _regGetValue(
}
});
} finally {
calloc
..free(pName)
..free(pResultSize)
..free(pType);
calloc..free(pName)..free(pResultSize)..free(pType);
}
// ignore: avoid_dynamic_calls
return _RegResults(pResult, pResultSize.value, type);
Expand Down Expand Up @@ -511,9 +508,7 @@ R _withRegKey<R>(
throw WindowsException(HRESULT_FROM_WIN32(result));
}
} finally {
calloc
..free(pOpenKey)
..free(pSubKey);
calloc..free(pOpenKey)..free(pSubKey);
}
return actionResult;
}
Expand Down Expand Up @@ -544,9 +539,7 @@ bool regKeyExists(
RegCloseKey(pOpenKey.value);
}
} finally {
calloc
..free(pOpenKey)
..free(pSubKey);
calloc..free(pOpenKey)..free(pSubKey);
}
return exists;
}
Expand Down Expand Up @@ -577,9 +570,7 @@ void regCreateKey(
}
RegCloseKey(pOpenKey.value);
} finally {
calloc
..free(pOpenKey)
..free(pSubKey);
calloc..free(pOpenKey)..free(pSubKey);
}
}

Expand Down
4 changes: 1 addition & 3 deletions dcli/lib/src/script/dart_sdk.dart
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,7 @@ class DartSdk {
}

/// use old dart2native
runArgs
..add(script.pathToScript)
..add('--output=$pathToExe');
runArgs..add(script.pathToScript)..add('--output=$pathToExe');

process = RunnableProcess.fromCommandArgs(
pathToDartToNativeExe!,
Expand Down
4 changes: 1 addition & 3 deletions dcli/lib/src/util/remote.dart
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,7 @@ class Remote {
cmdArgs.add('-A');
}
// disable psuedo terminal
cmdArgs
..add('-T')
..add(host);
cmdArgs..add('-T')..add(host);

final cmdLine = StringBuffer();
for (var command in commands) {
Expand Down
2 changes: 1 addition & 1 deletion dcli/lib/src/version/version.g.dart
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
/// GENERATED BY pub_release do not modify.
/// dcli version
String packageVersion = '1.20.2';
String packageVersion = '1.21.0';
10 changes: 4 additions & 6 deletions dcli/test/src/functions/find_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,13 @@ void main() {
createDir(path, recursive: true);
final pathToLicense = join(path, 'LICENSE$i');
touch(pathToLicense, create: true);
expected
..add(path)
..add(pathToLicense);
expected..add(path)..add(pathToLicense);
}
// /mnt/c/Users/Brett/AppData/Local/Pub/Cache/hosted/pub.dartlang.org'
expected = expected
//map((path) => join(rootPath, relative(path, from: '/mnt/c')))
.toList()
..sort((lhs, rhs) => lhs.compareTo(rhs));
..sort((lhs, rhs) => lhs.compareTo(rhs));

final actual = find(
'*',
Expand Down Expand Up @@ -122,7 +120,7 @@ void main() {
final found =
find('*.txt', workingDirectory: paths.top, recursive: false)
.toList()
..sort();
..sort();
final expected = [
truepath(paths.top, 'one.txt'),
truepath(paths.top, 'two.txt')
Expand Down Expand Up @@ -200,7 +198,7 @@ void main() {
final found =
find('*.txt', workingDirectory: paths.top, includeHidden: true)
.toList()
..sort();
..sort();
final expected = [
truepath(paths.thidden, 'fred.txt'),
truepath(paths.top, 'one.txt'),
Expand Down

0 comments on commit f3fd159

Please sign in to comment.