Major Overhaul: New Version of Go SDK - v0.4.0 #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare the v1.1.19 release
Prepare for release 1.1.20
Jmfwolf
added a commit
that referenced
this pull request
Jun 26, 2023
* Update to use subdomain rather than region Region based endpoint is only being allowed for backwards compatibility. Use subdomain going forward. * Include openapi-generator SDK. * Fix GIT_REPO_ID and GIT_USER_ID * Update go mod/sum * Add makefile back * v3.1.0 (#66) * V3.1.0 * Makefile that got left behind * changelog * changelog * release changes * revert * Major Overhaul: New Version of Go SDK - v0.4.0 (#67) * worked design * updated readme * convenience * Improved docs * improved model documentation * skeleton onelogin.go * some services implemented * fixed client requests * basic testing * validation is broken * added logging and request fixes * fixed const paths * updated docs, roles, users, apps, authservers * Updated readme * broken testing * services implemented missing mfa * service calls implemented * Updated Readme * added Makefile back * fixing tests * fixed readme link issue * fixed it right this time * add support for delete req body * working test package * Makefile runs unit tests * changed path name for secure * reorganized documentation * updated documents --------- Co-authored-by: Bryan Vestey <[email protected]> * Create changelog.md * update config --------- Co-authored-by: eriktalvi <[email protected]> Co-authored-by: George Khaburzaniya <[email protected]> Co-authored-by: Bryan Vestey <[email protected]> Co-authored-by: gkhaburzaniya-onelogin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a major overhaul of the Go SDK for Onelogin's API. The previous versions (v0.2.0+ and v0.3.0+) were incomplete and autogenerated from an OpenAPI specification that lacked necessary components. With this new version, v0.4.0, we have completely redesigned the SDK with a new architecture and implementation approach.
The SDK design document outlines the following key points:
The changes in this pull request reflects a more complete implementation of the design document, incorporating separate modules for authentication, API handling, models, error management, and utilities. We have introduced a facade module, "onelogin," that provides a simplified interface for users, shielding them from underlying complexities. Additionally, we have implemented dependency injection to allow users to customize or replace certain components, such as authentication mechanisms or the HTTP client implementation.
Comprehensive documentation has been added to guide users in integrating and utilizing the SDK effectively. We have also conducted thorough testing to ensure the SDK behaves as expected and handles errors appropriately.
Please review this pull request and consider it as a new major version of the Go SDK (v0.4.0). The previous versions (v0.2.0+ and v0.3.0+) should be considered incomplete and outdated. This major overhaul represents a significant improvement in the design, functionality, and usability of the SDK.
Thank you for your attention and consideration. We look forward to your feedback and suggestions for further improvements.