timeout checks and errs

onelogin · Jul 31, 2023 · 8e0c5a4 · 8e0c5a4
1 parent 92c13f2
commit 8e0c5a4
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/pkg/onelogin/api/client.go b/pkg/onelogin/api/client.go
@@ -41,19 +41,20 @@ func NewClient() (*Client, error) {
 	subdomain := os.Getenv("ONELOGIN_SUBDOMAIN")
 	old := fmt.Sprintf("https://%s.onelogin.com", subdomain)
 	authenticator := authentication.NewAuthenticator(subdomain)
-	timeout := os.Getenv("ONELOGIN_TIMEOUT")
-	if timeout == "" || timeout == nil {
+	timeoutStr := os.Getenv("ONELOGIN_TIMEOUT")
+	timeout, err := strconv.Atoi(timeoutStr)
+	if err != nil || timeout <= 0 {
 		timeout = 10
 	}
-	timeout := time.Second * timeout
+	timeoutDuration := time.Second * time.Duration(timeout)
 	err := authenticator.GenerateToken()
 	if err != nil {
 		return nil, err
 	}
 
 	return &Client{
 		HttpClient: http.Client{
-			Timeout: timeout,
+			Timeout: timeoutDuration,
 		},
 		Auth:       authenticator,
 		OLdomain:   old,