Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[L0] zeDeviceCanAccessPeer call optimization #2013

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

winstonzhang-intel
Copy link
Contributor

@winstonzhang-intel winstonzhang-intel commented Aug 27, 2024

The more cards used, zeDeviceCanAccessPeer time costing is becoming more and more expensive. Improved by caching p2p devices status thus reducing the number of zeDeviceCanAccessPeer calling times.

llvm/sycl PR: intel/llvm#15291

@github-actions github-actions bot added the level-zero L0 adapter specific issues label Aug 27, 2024
@winstonzhang-intel winstonzhang-intel marked this pull request as ready for review August 27, 2024 15:56
@winstonzhang-intel winstonzhang-intel requested a review from a team as a code owner August 27, 2024 15:56
Copy link
Contributor

@nrspruit nrspruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nrspruit
Copy link
Contributor

nrspruit commented Sep 3, 2024

Please post a intel/llvm patch for this change.

@nrspruit nrspruit added the ready to merge Added to PR's which are ready to merge label Sep 10, 2024
The more cards used, zeDeviceCanAccessPeer time costing is becoming
more and more expensive. Improved by caching p2p devices status thus
reducing the number of zeDeviceCanAccessPeer calling times.

Signed-off-by: Winston Zhang <[email protected]>
winstonzhang-intel added a commit to winstonzhang-intel/llvm that referenced this pull request Sep 18, 2024
winstonzhang-intel added a commit to winstonzhang-intel/llvm that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level-zero L0 adapter specific issues ready to merge Added to PR's which are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants