Fix driver sorting given driver failures and instrumentation #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nrspruit
commented
Feb 26, 2025
nrspruit
commented
- To avoid issues when sorting of the drivers can cause an invalid call during instrumentation after driver failures, then the driver sorting has been moved to occur during the call to zeDriverGet or zeinitDrivers.
- In addition, the driver type is not init to UINT32_MAX in the enum such that all failing drivers are forced to the back of the sorted list.
nrspruit
force-pushed
the
delay_driver_sorting
branch
2 times, most recently
from
dbe5e16 to
0276d13
Compare
rwmcguir
previously approved these changes
Feb 26, 2025
source/loader/ze_ldrddi.cpp
Outdated
| @@ -55,6 +55,10 @@ namespace loader | |||
|
|
|||
| uint32_t total_driver_handle_count = 0; | |||
|
|
|||
| if (!loader::context->coredriverSortingCompleted) { | |||
There was a problem hiding this comment.
what if zeDriverGet is called again within driverSorting function?
There was a problem hiding this comment.
Fixed in latest, the recursion is now prevented.
nrspruit
force-pushed
the
delay_driver_sorting
branch
3 times, most recently
from
1ac4a8f to
e2d5fdd
Compare
- To avoid issues when sorting of the drivers can cause an invalid call during instrumentation after driver failures, then the driver sorting has been moved to occur during the call to zeDriverGet or zeinitDrivers. - In addition, the driver type is not init to UINT32_MAX in the enum such that all failing drivers are forced to the back of the sorted list. Signed-off-by: Neil R. Spruit <[email protected]>
Signed-off-by: Neil R. Spruit <[email protected]>
Signed-off-by: Neil R. Spruit <[email protected]>
Signed-off-by: Neil R. Spruit <[email protected]>
…rting once Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
force-pushed
the
delay_driver_sorting
branch
from
e2d5fdd to
5e2e830
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.