[SYCLomatic] Enable migration of cudaStreamCaptureStatus enum and SYCL graphs exp option #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…L graphs exp option Signed-off-by: Ahmed, Daiyaan <[email protected]>
Signed-off-by: Ahmed, Daiyaan <[email protected]>
daiyaan-ahmed6
force-pushed
the
cudaStreamCaptureStatus_enum
branch
from
3b99638 to
ad5ede2
Compare
Signed-off-by: Ahmed, Daiyaan <[email protected]>
Signed-off-by: Ahmed, Daiyaan <[email protected]>
tangjj11
approved these changes
May 6, 2024
ShengchenJ
approved these changes
May 6, 2024
Signed-off-by: Ahmed, Daiyaan <[email protected]>
Signed-off-by: Ahmed, Daiyaan <[email protected]>
| @@ -758,6 +758,10 @@ DPCT_ENUM_OPTION( | |||
| "bindless_images", int(ExperimentalFeatures::Exp_BindlessImages), | |||
| "Experimental extension that allows use of bindless images APIs.\n", | |||
| false), | |||
| DPCT_OPTION_ENUM_VALUE( | |||
| "graphs", int(ExperimentalFeatures::Exp_Graphs), | |||
There was a problem hiding this comment.
Suggested change
| "graphs", int(ExperimentalFeatures::Exp_Graphs), | |
| "graph", int(ExperimentalFeatures::Exp_Graphs), |
| // CHECK-NEXT: DPCT1027:{{[0-9]+}}: The call to cudaStreamIsCapturing was replaced with 0 because SYCL currently does not support capture operations on queues. | ||
| // CHECK-NEXT: */ | ||
| // CHECK: MY_ERROR_CHECKER(0); | ||
| MY_ERROR_CHECKER(cudaStreamIsCapturing(s0, &captureStatus)); |
There was a problem hiding this comment.
from queue_state, can it know the a queue is in Capturing status?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daiyaan Ahmed [email protected]