Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCLomatic #1165] Add test for tagged_pointer #427

Merged
merged 5 commits into from
Oct 30, 2023
Merged

[SYCLomatic #1165] Add test for tagged_pointer #427

merged 5 commits into from
Oct 30, 2023

Conversation

mmichel11
Copy link
Contributor

This PR tests the dpct::tagged_pointer functionality provided in oneapi-src/SYCLomatic#1165 by performing various pointer arithmetic operations, conversions, and invokes oneDPL algorithms to ensure expected functionality.

@mmichel11 mmichel11 requested a review from a team as a code owner August 14, 2023 15:54
@mmichel11 mmichel11 mentioned this pull request Aug 14, 2023
Merged
danhoeflinger
danhoeflinger reviewed Aug 29, 2023
View reviewed changes
Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor stuff to fix.

help_function/src/onedpl_test_tagged_pointer.cpp Outdated Show resolved Hide resolved
help_function/src/onedpl_test_tagged_pointer.cpp Outdated Show resolved Hide resolved
help_function/src/onedpl_test_tagged_pointer.cpp Outdated Show resolved Hide resolved
help_function/src/onedpl_test_tagged_pointer.cpp Outdated Show resolved Hide resolved
help_function/src/onedpl_test_tagged_pointer.cpp Outdated Show resolved Hide resolved
tomflinda
tomflinda reviewed Aug 31, 2023
View reviewed changes
Copy link
Contributor

@tomflinda tomflinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls re-run the CI test.

danhoeflinger
danhoeflinger approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failures seem to be with device segmented sort, which should be unrelated to this PR.
From the code this LGTM.

@danhoeflinger
Copy link
Contributor

@tomflinda I believe this PR should be ready to merge, the failing CI is unrelated. I do not have privileges to merge.

tomflinda
tomflinda approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@tomflinda tomflinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmichel11 mmichel11 force-pushed the dev/mmichel11/add_tagged_pointer_test branch from 460c106 to 4a01baf Compare October 26, 2023 18:27
@mmichel11
Copy link
Contributor Author

I have rebased and resolved the conflict from #426

@zhimingwang36 zhimingwang36 merged commit 8071d49 into oneapi-src:SYCLomatic Oct 30, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danhoeflinger danhoeflinger danhoeflinger approved these changes

@tomflinda tomflinda tomflinda approved these changes

@tangjj11 tangjj11 Awaiting requested review from tangjj11 tangjj11 is a code owner automatically assigned from oneapi-src/syclomatic-reviewers

@zhimingwang36 zhimingwang36 Awaiting requested review from zhimingwang36 zhimingwang36 is a code owner automatically assigned from oneapi-src/syclomatic-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmichel11 @danhoeflinger @tomflinda @zhimingwang36