Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPSO Temperature Object using sdfChoice and OMA IDs #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

akeranen
Copy link
Collaborator

Measurement_Quality_Indicator resource uses sdfChoice parsed from the description. All definitions also contain Object/Resource IDs.

@dnav
Copy link

dnav commented Mar 26, 2023

A general question that came to me reading this PR:

In LwM2M data model, this object is defined as allowing multiple instances. Should this appear in the SDF model? Or is it managed during the composition, something like this:

"sdfThing": {
    "HigherThing": {
      "sdfObject": {
        "temperature" {
          "sdfRef": "oma:#/sdfObject/Temperature",
          "minItems": 0
        }
      }
    }
  }

"Sensor_Value": {
"label": "Sensor Value",
"description": "Last or Current Measured Value from the Sensor.",
"oma:id": 5700,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is probably just me, but I can't find mentions of such namespace-specific qualities in draft-13.

Copy link
Collaborator Author

@akeranen akeranen Mar 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The possibility to use namespace'd quality extensions is mentioned in section 2.3.3 but we still need to finalise the spec on this and add IANA registry for the namespaces (this is a different namespace than the definition namespace).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually in SDF models you would leave ecosystem specific details (like OMA IDs) to the mapping file, but I happened to run the conversion tool with ID in-lining mode in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants