Site 3912 #110
Site 3912 #110
Conversation
|
Need to address build error before merging (type error). |
| @@ -6,7 +6,7 @@ | |||
| "experimentalTernaries": false, | |||
| "singleQuote": true, | |||
| "jsxSingleQuote": false, | |||
| "quoteProps": "as-needed", | |||
| "quoteProps": "consistent", | |||
There was a problem hiding this comment.
any specific reason for this change?
There was a problem hiding this comment.
Packaging the api calls was difficult without it, prettier kept removing the quotes from the headers when saving. I tried to find a workaround for a while but I had to settle for that eventually
There was a problem hiding this comment.
Instead of updating all the emails in the file to ett.healthit.gov, may be should have tackle with logic to either change to ett.healthit.gov or ett.dev.sitenv.org because the domain is different for dev. This could be probably be post release to support both
There was a problem hiding this comment.
Oh good idea, I assume this would be an environment variable then
There was a problem hiding this comment.
May be this https://www.npmjs.com/package/react-syntax-highlighter that Matt mentioned could be helpful. Something to look at later, so dont have to do it manually.
No description provided.