Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site 3912 #110

Merged
merged 41 commits into from
Aug 29, 2024
Merged

Site 3912 #110

merged 41 commits into from
Aug 29, 2024

Conversation

ebrockainq
Copy link
Contributor

No description provided.

@drbgfc
Copy link
Contributor

drbgfc commented Aug 28, 2024

Need to address build error before merging (type error).
I also need to fully review

@@ -6,7 +6,7 @@
"experimentalTernaries": false,
"singleQuote": true,
"jsxSingleQuote": false,
"quoteProps": "as-needed",
"quoteProps": "consistent",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any specific reason for this change?

Copy link
Contributor Author

@ebrockainq ebrockainq Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Packaging the api calls was difficult without it, prettier kept removing the quotes from the headers when saving. I tried to find a workaround for a while but I had to settle for that eventually

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of updating all the emails in the file to ett.healthit.gov, may be should have tackle with logic to either change to ett.healthit.gov or ett.dev.sitenv.org because the domain is different for dev. This could be probably be post release to support both

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good idea, I assume this would be an environment variable then

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be this https://www.npmjs.com/package/react-syntax-highlighter that Matt mentioned could be helpful. Something to look at later, so dont have to do it manually.

@akanuri9 akanuri9 merged commit 1e09a80 into dev Aug 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants