feat: nextauth implementation #108
Conversation
| @@ -8,9 +8,8 @@ import SiteAppBar from '@/components/shared/nav/app-bar/SiteAppBar' | |||
| import Nav from '@/components/shared/nav/nav/Nav' | |||
|
|
|||
| export default function CombinedNavAndAppBar() { | |||
| const [auth, setAuth] = React.useState(false) | |||
| const handleAuthChange = (event: React.ChangeEvent<HTMLInputElement>) => { | |||
There was a problem hiding this comment.
I don't think the function handleAuthChange, or passing it around, serves any purpose anymore. Since you have reworked what represents that, we should probably pass w/e that is instead. But, I get why you left it in place, so we can update if we have time/if we need it. And, otherwise, remove. So, this is really just a note for anyone curious. Not a reason to hold up a PR.
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars, @typescript-eslint/no-explicit-any | ||
| export default function Auth(props: any) { |
There was a problem hiding this comment.
There are no props referenced so do we need the param and the lint exception?
| @@ -91,8 +90,7 @@ export default function SiteAppBar({ open, handleDrawerOpen, auth }: SiteAppBarP | |||
| </a> | |||
| </Grow> | |||
| </div> | |||
| {/* Login */} | |||
| <Auth auth={auth} /> | |||
| <Auth /> | |||
There was a problem hiding this comment.
just confirming no props are sent
| CredentialsProvider({ | ||
| name: 'ETT Login', | ||
| credentials: { | ||
| username: { label: 'Username', type: 'text', placeholder: 'jsmith' }, |
There was a problem hiding this comment.
should we provide a placeholder suggestion for a value for a username?
| @@ -0,0 +1,3 @@ | |||
| 'use client' | |||
There was a problem hiding this comment.
Nice. We should use this technique more often.
There was a problem hiding this comment.
Thanks for the hard work! There is nothing in my comments that warrants holding up this PR that's for sure. @Plow74 when you get a chance, please review, and if you feel there is any merit (and there very well may not be!) include alongside a relevant update for a newer ticket.
No description provided.