Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-1995: Changes for HL7 validator v6.0.21 #449

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Conversation

dehall
Copy link
Contributor

@dehall dehall commented Jul 11, 2023

The validator wrapper is being upgraded to use the most recent version of the HL7 validator (6.0.21 as of now, see inferno-framework/fhir-validator-wrapper#61), and that version of the validator produces some slightly different output compared to the version we previously used (5.6.93):

  1. Code displays that do not match the official display are now errors by default. This can be changed to match the old behavior with the environment variable "DISPLAY_ISSUES_ARE_WARNINGS" set to true.

  2. There's now an error message received when testing US Core 3.1.1 related to a constraint that cannot be met due to a bad profile, see message below. This was seen previously with slightly different text ( https://chat.fhir.org/#narrow/stream/179309-inferno/topic/Pulse.20Oximetry.20Flow.20Rate.20units )

Observation/313: Observation.component[0].value.ofType(Quantity): The code provided (http://unitsofmeasure.org#L/min) is not in the value set 'Vital Signs Units' (http://hl7.org/fhir/ValueSet/ucum-vitals-common%7C4.0.1), and a code from this value set is required: Unable to check whether the code is in the value set http://hl7.org/fhir/ValueSet/ucum-vitals-common%7C4.0.1

Because we're already ignoring/excluding certain validator messages I added this one to that list.

This is marked as draft until we tag & release a new version of the validator wrapper. (Though technically these should be backwards compatible in the sense that nothing will happen if the environment variable is set on a library that doesn't support it, and ignoring the error message shouldn't have any unexpected effects either)

Testing Guidance:
Run the test suites against the inferno reference server and pointing to an updated version of the validator: inferno-framework/fhir-validator-wrapper#61
Ensure all tests pass

@dehall dehall changed the title WIP: FI-1995: Changes for HL7 validator v6.0.22 FI-1995: Changes for HL7 validator v6.0.21 Jul 12, 2023
@dehall dehall marked this pull request as ready for review August 2, 2023 14:44
@dehall dehall merged commit d8d9446 into main Aug 8, 2023
3 checks passed
@dehall dehall deleted the fi-1995-new-hl7-validator branch August 8, 2023 12:48
@arscan arscan mentioned this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants