Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lantern 579 Fix eMedPractice webscraper #390

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

archita-ekkirala
Copy link
Contributor

@archita-ekkirala archita-ekkirala commented Aug 22, 2024

Pull requests into this repository require the following checks to be completed by the submitter and reviewers.

Submitter:

  • Administrative tasks are complete.
    • This pull request describes why these changes were made.
    • The JIRA ticket links to this PR.
    • The JIRA ticket for this PR is:
  • Tests are complete.
    • Tests are included and test edge cases.
    • Tests have been run locally and pass.
  • Code review has been performed.
    • Code diff has been done and checked to ensure only expected code is being committed.
    • A linter for the language has been run.

Primary Reviewer:

  • Code works.
    • Code has been run locally and the basic functionality affected by the PR has been checked.
    • Edge cases have been checked to ensure behavior is as expected.
  • Code review has been performed.
    • Code is maintainable, reusable, efficient, and correct.
    • Code accomplishes the tasks purpose.
    • Code follows style guidance appropriate for the language, including passing linter checks.
    • Code is well commented (which does not mean verbosely commented).
  • Tests are complete.
    • Tests are included and test edge cases.
    • Tests have been run locally and pass.

Merger:

Prior to merging, ensure that all checks have been completed. Delete the branch after the merge
is complete.

@archita-ekkirala archita-ekkirala changed the title Lantern 579 fix e med practice webscraper Lantern 579 Fix eMedPractice webscraper Aug 22, 2024
@bcalvert3
Copy link

@archita-ekkirala What is the plan for the failed "Static Analysis / Go Lintr (push)"? @vishnu-mettles for awareness

@archita-ekkirala
Copy link
Contributor Author

archita-ekkirala commented Sep 6, 2024

@bcalvert3 The fix for the Go Linter error has already been merged into the main branch as part of this commit: [https://github.com/onc-healthit/lantern-back-end/commit/2b1f76b2157755a392b1518e3284143cffdedcdb]

The reason we’re encountering the Linter error now is that the branch for this PR underwent development and was branched off of main before the fix was merged into main. This issue will resolve once we merge the branch back into the main branch.

@vishnu-mettles vishnu-mettles merged commit 30223d5 into main Sep 10, 2024
4 of 5 checks passed
@vishnu-mettles vishnu-mettles deleted the LANTERN-579-Fix-eMedPracticeWebscraper branch September 10, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants