Ntd/add students page and reducer #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshthepitt
suggested changes
May 15, 2020
|
@kahummer can you add a screenshot(s) please? |
moshthepitt
suggested changes
May 15, 2020
|
@kahummer why is the code coverage going down with this PR? |
kahummer
force-pushed
the
NTD/add-students-page-and-reducer
branch
3 times, most recently
from
a650e84 to
39805e4
Compare
|
@moshthepitt @rkodev Seems Organizationselect was built relying on team assignment props. The pr has has not addressed this issue due to time constraints. |
kahummer
force-pushed
the
NTD/add-students-page-and-reducer
branch
from
a440694 to
eefd6dd
Compare
Drill down to location level
moshthepitt
approved these changes
Jun 5, 2020
* mda-staging: Remove comment Fix MDA and IRS reporting failling tests Make jurisdiction reporting helpers not tied to IRS Add extra tests for IRS reporting planList Refactor MDA reporting plans list failling tests Fix MDA reporting plans list failling tests Refactor IRS Plan list to use GenericPlanLists component Refactor MDA Plan list to use GenericPlanLists component Create a generic plans list component Update MDA jurisdictions snapshots Refactor IRS JurisdictionReport page to use GenericJurisdiction component Refactor MDA point JurisdictionReport page to use GenericJurisdiction component Add page for generic jurisdiction reports Add tests for MDA point jurisdictionsReport page Add tests for MDA point jurisdiction columns Add MDA point plans tests Rename variables in MDA point store tests file Add tests for MDA point actions and reducers Update failling snapshots Don't use IRSTableCell when plan is not IRS Change type name IRSPlan to GenericPlan Add doc strings for jurisdictionReport page props Rename MDAPoint reducer and actions page name Hide map link for mda point jurisdictions on the drill down Update failling Headers snapshots Add mda point jurisdiction colums Rename variable in MdaJurisdiction page Fix APP component failling tests Add mda jurisdiction report links Add mdapoint jurisdiction report page Make 'JurisdictionReport' page reusable Refactor mda point page to use irs plans page Make IRS Plans page reusable Create router for mda point plans Add mda point plans page Add reducer and actions for mda point plans Update headers component failling snapshots Add MDA point reporting link to monitor dropdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For opensrp/opensrp-client-reveal#679
This PR
Upload Modal