include nested location ids in client search #917
Conversation
machariamuguku
commented
Jan 27, 2022
machariamuguku
commented
- closes [Bug Report]: TuneVacc Card Support Locations not loading correctly #900
- fetch all nested location ids for the selected location in the hierarchy tree; to be included in fetching download data
…ree to be included in fetching download data
…cation ids and mocked endpoint call, add test for endpoind fetch failure
| <TreeNode | ||
| title="CSB Hopital Bouficha" | ||
| value="e2b4a441-21b5-4d03-816b-09d45b17cad7" | ||
| /> |
There was a problem hiding this comment.
Q: why did this change
There was a problem hiding this comment.
That's the correct behavior, no location selected at render
There was a problem hiding this comment.
Correct me if am wrong, looks like this is not a snapshot of the options after a select, but a general snapshot of the options that exist in this particular treeSelect, during first render there should be 2 options the All locations and root location, as shown here
There was a problem hiding this comment.
Only one label until you click the dropdown
There was a problem hiding this comment.
I take it back, the tests failed. I think it's a disconnect between the CI and local setup. Ought to be checked out
| @@ -285,7 +300,7 @@ describe('components/DownloadClientData/utils/submitForm', () => { | |||
| OpenSRPService, | |||
| fixtures.locations, | |||
| setSubmittingMock | |||
| ); | |||
| ).catch(() => {}); | |||
There was a problem hiding this comment.
add a jest mock function and test if its called when the promise is rejected
machariamuguku
deleted the
900-include-nested-location-ids-in-client-search
branch
