Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Update the Keycloak admin URLs #296

Merged
merged 6 commits into from
Dec 18, 2024

Conversation

dubdabasoduba
Copy link
Member

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #[issue number] or Closes #[issue number]

Engineer Checklist

  • I have run ./gradlew spotlessApply to check my code follows the project's style guide
  • I have built and run the efsity jar to verify my change fixes the issue and/or does not break the application

@dubdabasoduba dubdabasoduba added the Bug Report Something isn't working label Oct 7, 2024
@dubdabasoduba dubdabasoduba requested a review from Wambere October 7, 2024 20:16
@dubdabasoduba dubdabasoduba self-assigned this Oct 7, 2024
@@ -244,18 +244,19 @@ def confirm_practitioner(user, user_id):
def create_roles(role_list, roles_max):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove roles_max from the params here since it's not used any more?
from where it's called in main.py as well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any update on this?

@dubdabasoduba dubdabasoduba changed the title 🐛 (Update the Keycloak adm in URLs): Update the Keycloak admin URLs 🐛 Update the Keycloak admin URLs Oct 28, 2024
@dubdabasoduba dubdabasoduba merged commit e035ab5 into main Dec 18, 2024
4 checks passed
@dubdabasoduba dubdabasoduba deleted the feature/update_keycloak_admin_urls branch December 18, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants