Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding minimal PHP-Version to composer package #44

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

legionth
Copy link
Member

@legionth legionth commented Mar 21, 2022

Should also work for >= 8 versions.

@legionth
Copy link
Member Author

Need to add composer.lock, but don't have composer on my machine. Will update tonight (or another night) with my other laptop.

@jayay
Copy link
Contributor

jayay commented Mar 28, 2022

This should also give Dependabot a hint on which versions of PHP must be supported. I'm not asking for this to be added unless you're absolutely sure what it does when this package is being used as a dependency in another project, since the documentation is being imprecise about this. See https://getcomposer.org/doc/06-config.md#platform
I want to avoid other projects using this package to get their dependencies pulled as if they'd be running PHP 7.0, even though they're not.

@legionth
Copy link
Member Author

TIL platform :D

@jayay
Copy link
Contributor

jayay commented Mar 29, 2022

I think php-cs-fixer is the problem here.
What do you think about removing php-cs-fixer from the package.json for now, since the GH Action doesn't execute it anyway?
If desired, we could setup php-cs-fixer from a PHAR file in a separate action or task that runs a current version of PHP. Different ways to install it globally are documented here: https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/master/doc/installation.rst
That could be a follow-up PR, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants