feature/archive account #4350
Merged
feature/archive account #4350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sywhb
commented
Aug 29, 2024
sywhb
commented
- allow omnivore_admin to delete filters
- add archived status to user account
- redirect archived user to /export page when login
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sywhb
commented
Aug 29, 2024
| @@ -40,12 +40,11 @@ export const refreshAllFeeds = async (db: DataSource): Promise<boolean> => { | |||
| FROM | |||
| omnivore.subscriptions s | |||
| INNER JOIN | |||
| omnivore.user u ON u.id = s.user_id | |||
| omnivore.user u ON u.id = s.user_id AND u.status = $4 | |||
There was a problem hiding this comment.
Optimized the query a little bit here
sywhb
commented
Aug 29, 2024
| @@ -1039,7 +1039,10 @@ export const updateLibraryItemReadingProgress = async ( | |||
| } | |||
|
|
|||
| const updatedItem = result[0][0] | |||
| await pubsub.entityUpdated<ItemEvent>(EntityType.ITEM, updatedItem, userId) | |||
| if (updatedItem.readingProgressBottomPercent === 100) { | |||
There was a problem hiding this comment.
Here I try to reduce the number of PAGE_UPDATE event being sent so we only send the event when the item is fully read or reset to unread
sywhb
force-pushed
the
feature/archive-account
branch
from
89c254d
to
43fb698
Compare
jacksonh
reviewed
Aug 30, 2024
| @@ -158,15 +157,16 @@ export async function handleGoogleWebAuth( | |||
| } | |||
| } | |||
|
|
|||
| let redirectURL = `${baseURL()}${ | |||
| user.status === StatusType.Archived ? '/export' : DEFAULT_HOME_PATH | |||
There was a problem hiding this comment.
Can we change this to /account-archived.
|
Just one small change on the path |
jacksonh
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.