sdns: Add new package to repo #1457
Conversation
build/sdns/local.mog
Outdated
| # source. A copy of the CDDL is also available via the Internet at | ||
| # http://www.illumos.org/license/CDDL. | ||
|
|
||
| # Copyright 2024 Guo-Rong Koh |
There was a problem hiding this comment.
Hmm, I don't remember writing this 😂
|
Im sorry, I scavenged through gh and mattermost and nsd to piece together all the moving parts for this!
This is what I get for keeping changes to a minimal.. 😅
Sent via BlackBerry Hub+ Inbox for Android<http://play.google.com/store/apps/details?id=com.blackberry.hub>
From: ***@***.***
Sent: May 15, 2024 06:34
To: ***@***.***
Reply-to: ***@***.***
Cc: ***@***.***; ***@***.***
Subject: Re: [omniosorg/omnios-extra] sdns: Add new package to repo (PR #1457)
@gkoh commented on this pull request.
________________________________
In build/sdns/local.mog<#1457 (comment)>:
@@ -0,0 +1,26 @@
+#
+# This file and its contents are supplied under the terms of the
+# Common Development and Distribution License ("CDDL"), version 1.0.
+# You may only use this file in accordance with the terms of version
+# 1.0 of the CDDL.
+#
+# A full copy of the text of the CDDL should have accompanied this
+# source. A copy of the CDDL is also available via the Internet at
+# http://www.illumos.org/license/CDDL.
+
+# Copyright 2024 Guo-Rong Koh
Hmm, I don't remember writing this 😂
—
Reply to this email directly, view it on GitHub<#1457 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADF4KZP3A555LTPQIY3SY23ZCM23BAVCNFSM6AAAAABHWGJR6WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJXGU4DINJSHE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
No problems! |
build/sdns/build.sh
Outdated
| # http://www.illumos.org/license/CDDL. | ||
| # }}} | ||
|
|
||
| # Copyright 2022 OmniOS Community Edition (OmniOSce) Association. |
There was a problem hiding this comment.
can you please update the year to 2024
| init | ||
| clone_go_source $PROG semihalev v$VER | ||
| patch_source | ||
| print_config |
There was a problem hiding this comment.
this looks like a leftover from another build.sh
build/sdns/local.mog
Outdated
| group groupname=$(PROG) gid=5353 | ||
| user ftpuser=false username=$(PROG) uid=5353 group=$(PROG) \ |
There was a problem hiding this comment.
system UIDs should be below 100 to avoid clashes with user IDs. have a look at doc/idlist.md and look for a free uid/gid pair (e.g. 58). and document the ID you are using in idlist.md.
This file was based on other projects throughout the omnios-extra, tree - the authors of which I am very thankful for! 😁
Tentatively taking UID 35 (opposite of 53), unless there are objections.
|
ping @hadfl |
There was a problem hiding this comment.
Hello, thank you for the pull request and apologies for the delay in looking at this. hadfl won't be able to get back to it for a while so I've taken a look through and left a couple of comments.
Please could you also update the doc/packages.md and doc/baseline files for this new package?
Thanks again.
|
@gkoh ping |
Sorry, this is not my PR. I only commented because my name was 'used in vain'. |
|
@justledbetter ping! |
|
Apologies, have been out of town! Will get back on this shortly! |
|
Thanks again to everyone for your feedback, and most importantly for your patience! Hopefully things look better after the latest commits :) |
| @@ -85,6 +85,7 @@ | |||
| | illumos | 25 | smmsp | |||
| | extra | 27 | postfix | |||
| | extra | 28 | postdrop | |||
| | extra | 35 | sdns | |||
There was a problem hiding this comment.
It looks like you misinterpreted the input from @citrus-it. Yes we need this in groups since you allocate the sdns gid. But you'll also need to leave your initial entry in users, as you allocate a uid as well
|
I think you have overlooked the comments regarding removing Sorry again, that getting back to this review took so long. |
|
@justledbetter it seems there is still a bit of stuff left seee the last comment form @hadfl ! |
I've added the sdns package (https://github.com/semihalev/sdns) to the repo, and confirmed it builds and appears to startup/shutdown correctly. This is my first attempt at doing any of this, so please forgive me if anything is amiss! :)