feat: Add async constructors for GitOid. #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits adds two new constructors for `GitOid` to build new GitOIDs from async readers, with or without an expected length being provided. This was pretty easy! I've generally stayed away from doing async things because of the general vibe that it's kinda finicky / difficult. I'm happy this was so simple to do. Signed-off-by: Andrew Lilley Brinker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits adds two new constructors for
GitOidto build newGitOIDs from async readers, with or without an expected length
being provided.
This was pretty easy! I've generally stayed away from doing async
things because of the general vibe that it's kinda finicky / difficult.
I'm happy this was so simple to do.
Signed-off-by: Andrew Lilley Brinker [email protected]
Description
Related Issue
Motivation and Context
How Has This Been Tested?