Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for secret string types #416

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Support for secret string types #416

merged 1 commit into from
Nov 2, 2023

Conversation

mauvilsa
Copy link
Member

Before submitting

  • Did you read the contributing guideline?
  • Did you update the documentation? (readme and public docstrings)
  • Did you write unit tests such that there is 100% coverage on related code? (required for bug fixes and new features)
  • Did you verify that new and existing tests pass locally?
  • Did you make sure that all changes preserve backward compatibility?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

@mauvilsa mauvilsa added the enhancement New feature or request label Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f434635) 100.00% compared to head (018d083) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #416   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         5919      5934   +15     
=========================================
+ Hits          5919      5934   +15     
Flag Coverage Δ
py3.10 88.27% <100.00%> (+0.02%) ⬆️
py3.10_all 98.71% <100.00%> (+<0.01%) ⬆️
py3.10_pydantic1 48.33% <60.00%> (+0.02%) ⬆️
py3.10_pydantic2 48.06% <60.00%> (+0.03%) ⬆️
py3.10_types 98.71% <100.00%> (+<0.01%) ⬆️
py3.11 88.25% <100.00%> (+0.02%) ⬆️
py3.11_all 98.71% <100.00%> (+<0.01%) ⬆️
py3.11_types 98.71% <100.00%> (+<0.01%) ⬆️
py3.12 88.25% <100.00%> (+0.02%) ⬆️
py3.12_all 98.71% <100.00%> (+<0.01%) ⬆️
py3.12_types 98.71% <100.00%> (+<0.01%) ⬆️
py3.7 88.84% <100.00%> (+0.02%) ⬆️
py3.7_all 99.48% <100.00%> (+<0.01%) ⬆️
py3.7_types 99.47% <100.00%> (+<0.01%) ⬆️
py3.8 88.99% <100.00%> (+0.02%) ⬆️
py3.8_all 99.51% <100.00%> (+<0.01%) ⬆️
py3.8_types 99.49% <100.00%> (+<0.01%) ⬆️
py3.9 88.84% <100.00%> (+0.02%) ⬆️
py3.9_all 99.37% <100.00%> (+<0.01%) ⬆️
py3.9_types 99.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
jsonargparse/typing.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- New SecretStr type in jsonargparse.typing to provide secret support without additional dependency.
Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mauvilsa mauvilsa merged commit dd2d067 into main Nov 2, 2023
17 checks passed
@mauvilsa mauvilsa deleted the secrets branch November 2, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant