Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix choices working incorrectly when nargs is +, * or number #410

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

mauvilsa
Copy link
Member

Before submitting

  • Did you read the contributing guideline?
  • [n/a] Did you update the documentation? (readme and public docstrings)
  • Did you write unit tests such that there is 100% coverage on related code? (required for bug fixes and new features)
  • Did you verify that new and existing tests pass locally?
  • Did you make sure that all changes preserve backward compatibility?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

@mauvilsa mauvilsa added the bug Something isn't working label Oct 24, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (915b047) 100.00% compared to head (f49f7f3) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #410   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         5888      5892    +4     
=========================================
+ Hits          5888      5892    +4     
Flag Coverage Δ
py3.10 88.18% <100.00%> (+<0.01%) ⬆️
py3.10_all 98.71% <100.00%> (+<0.01%) ⬆️
py3.10_pydantic1 48.28% <16.66%> (-0.04%) ⬇️
py3.10_pydantic2 48.01% <16.66%> (-0.04%) ⬇️
py3.10_types 98.71% <100.00%> (+<0.01%) ⬆️
py3.11 88.17% <100.00%> (+<0.01%) ⬆️
py3.11_all 98.71% <100.00%> (+<0.01%) ⬆️
py3.11_types 98.71% <100.00%> (+<0.01%) ⬆️
py3.7 88.76% <100.00%> (+<0.01%) ⬆️
py3.7_all 99.48% <100.00%> (+<0.01%) ⬆️
py3.7_types 99.46% <100.00%> (+<0.01%) ⬆️
py3.8 88.91% <100.00%> (+<0.01%) ⬆️
py3.8_all 99.50% <100.00%> (+<0.01%) ⬆️
py3.8_types 99.49% <100.00%> (+<0.01%) ⬆️
py3.9 88.76% <100.00%> (+<0.01%) ⬆️
py3.9_all 99.37% <100.00%> (+<0.01%) ⬆️
py3.9_types 99.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
jsonargparse/_core.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauvilsa mauvilsa merged commit b571fc1 into main Oct 24, 2023
@mauvilsa mauvilsa deleted the fix-choices-nargs branch October 24, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant