Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug [Samsung_HVAC]: Does not compile with ESPHome 2024.12.x And esp-idf framework #242

Closed
mbo18 opened this issue Dec 28, 2024 · 2 comments · Fixed by #243
Closed

Bug [Samsung_HVAC]: Does not compile with ESPHome 2024.12.x And esp-idf framework #242

mbo18 opened this issue Dec 28, 2024 · 2 comments · Fixed by #243
Assignees
Labels
bug Something isn't working

Comments

@mbo18
Copy link
Contributor

mbo18 commented Dec 28, 2024

The problem

I’m unable to compile the code since ESPHome 2024.12.x. It was compiling correctly with ESPHome 2024.11.x

After some tests, it does compile when using "arduino" as framework type but no more with "esp-idf"

See attached logs

ESPHome Version

2024.12.2

Samsung HVAC Component Version

Latest

Home Assistant Version

2024.12.5

AC Type

NASA

Indoor AC Unit Model

AR09TXCAAWKN

Outdoor AC Unit Model

AR09TXCAAWKX

ESP Device Model

M5stack atom lite + m5stack rs485

Connection Points

F1/F2

ESPHome Logs

logs_salon-hvac_run.txt

Samsung AC Logs

No response

YAML Configuration

esp32:
  board: m5stack-atom
  framework:
    type: esp-idf

uart:
  tx_pin: GPIO19
  rx_pin: GPIO22
  baud_rate: 9600
  parity: EVEN

external_components:
  - source: github://omerfaruk-aran/esphome_samsung_hvac_bus@main
    components: [samsung_ac]

samsung_ac:
  debug_log_messages_raw: false
  debug_log_messages: false
  capabilities:
    vertical_swing: true
    horizontal_swing: true
    presets: 
      quiet: true
      windfree: true
      fast: true
  devices:
    - address: "20.00.00"
      climate:
        name: None
      room_temperature_offset: -2.0
      automatic_cleaning:
        name: "Automatic cleaning"
    - address: "10.00.00"
      outdoor_temperature:
        name: "Outdoor temperature"
      outdoor_instantaneous_power:
        name: "Power"
        accuracy_decimals: 0
      outdoor_cumulative_energy:
        name: "Energy"
        accuracy_decimals: 2

Additional Details

No response

@mbo18 mbo18 added the bug Something isn't working label Dec 28, 2024
@omerfaruk-aran
Copy link
Owner

Hi @mbo18 ,

I’ve created a PR (#243) addressing the issue you reported regarding the compilation failure with ESPHome 2024.12.x when using the ESP-IDF framework. The changes involve updating the debug_mqtt.cpp file to align with the new ESP-IDF API while maintaining backward compatibility with the Arduino framework.

I’d like you to test with your setup to confirm it resolves the issue.

external_components:
  - source: github://omerfaruk-aran/esphome_samsung_hvac_bus@branch-name
    components: [samsung_ac]

samsung_ac:

  # Sends all NASA package values to MQTT so the can be analysed or monitored.
  debug_mqtt_host: 192.168.1.100
  debug_mqtt_port: 1883
  debug_mqtt_username: mqtt_user
  debug_mqtt_password: mqtt_pass

    ...

@mbo18
Copy link
Contributor Author

mbo18 commented Dec 28, 2024

Hi @omerfaruk-aran,

Thank you very much for your work and reply. It works now! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants