Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate IDR PNG logos with transparent background #545

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Nov 2, 2021

Also generate a white version of the logo as used in presentations

The SVG files are unchanged but the PNG files have been regenerated with transparent background (to facilitate the embedding e.g. in presentations) and a white version of the PNG, similar to the ones used in the header of the standard IDR slides has been created.

NB: I am parallely starting to look into managing the sources and the generation of the raster image (see https://github.com/sbesson/artwork and https://github.com/sbesson/artwork/actions/runs/1414246457). I currently envision modifications to the logos would be release assets of the artwork repository and could be consumed in this repository (and others). I am happy to take any suggestions on tying (or not) both efforts.

Also generate a white version of the logo as used in presentations
@sbesson
Copy link
Member Author

sbesson commented Nov 18, 2021

https://github.com/sbesson/artwork is probably now in a state where it can be reviewed:

  • sources (SVG versions) are kept under version control
  • PNG versions are generated with a transparent background (ImageMagick 7/OSX)
  • a build script generates all PNGs and creates 3 zips (OME, OME products, IDR)
  • GHA runs the builds and creates artifacts for each PR and create a release with assets on tag - see https://github.com/sbesson/artwork/releases/tag/2021.11.16

If we are happy with this approach, I'd propose to migrate the repo to the ome org, recreate a release to test the process and update the zips in this repository with official release assets.

@sbesson sbesson requested review from jburel and joshmoore November 18, 2021 06:32
@joshmoore
Copy link
Member

  • Happy with the approach
  • The PNGs look good
  • Outwith this PR:
    • I could imagine some of them with white or black backgrounds
    • I could almost imagine as well having them unzipped for hot-linking but an alternative would be to have a single page that consumes all of them in some re-usable display

@sbesson
Copy link
Member Author

sbesson commented Nov 18, 2021

Cheers. I'll leave another day for comments and then go ahead with the repo transfer.

Outwith this PR:
I could imagine some of them with white or black backgrounds
I could almost imagine as well having them unzipped for hot-linking but an alternative would be to have a single page that consumes all of them in some re-usable display

Proposing to capture these as issues/RFE. For the second one, I assume https://www.openmicroscopy.org/artwork/ could become this page and give access either to bundles (like https://github.com/logos) and/or individual files (like https://git-scm.com/downloads/logos). There might be a case for generating another release artifact with all the logos (SVG + PNG) that could easily be extracted here.

@joshmoore
Copy link
Member

joshmoore commented Nov 18, 2021

Proposing to capture these as issues/RFE.

👍

Also, not exactly what we need but: https://calibreapp.com/blog/compress-images-in-prs ;)

@joshmoore
Copy link
Member

I'll leave another day for comments and then go ahead with the repo transfer.

👍

@jburel
Copy link
Member

jburel commented Apr 15, 2022

Sorry I completely missed this PR. Things look good. Include in the next deployment?

@sbesson
Copy link
Member Author

sbesson commented Apr 18, 2022

Re-reading the thread, I think there are two issues which conflated and put this on hold:

  • the generation of PNG with transparent background
  • the management of the SVG sources for all our logos/icons

The latter is still waiting on a decision regarding the licensing.

The former should be ready to go although looking at it again, it raises the question of whether we would want to generate both types of PNG (white background and transparent background) and use a suffix to differentiate them.

@joshmoore
Copy link
Member

Sorry for letting this slip. Concentrating on the former, my ordering would be:

  • All (e.g. here)
  • Just transparent
  • Whatever else

But since this is currently in place with the second best choice, I'm happy to get it in and we can go from there. Thanks, @sbesson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants