Remove the generation of Ivy dependencies.html files #6031
Conversation
With the recent work on OMERO 5.5, these files currently weight 169M out of 480M for the complete server bundle. In addition to being extremely large, their size makes them almost non-usable.
|
From the discussion we had, this PR did not have the expected size reduction. |
|
Finally managed to spend a bit of time on it: So this PR does not save much in terms of bundled server size (assuming most of the generated HTML are easily compressed) but it still saves ~170M when uncompressing the bundles. Size being one aspect, another point for discussion is the usability of these files. I initially tried to use them to troubleshoot some dependency conflict/eviction. But it turns out the size makes these reports barely usable as they are (and I could not find an option to shorten the report). |
|
I've found them useful for checking for conflicts and their outcome so it's nice they can be generated but I don't see why they need to be packaged in the artifact and I guess Ivy's days are numbered anyway. |
|
(I just do something else while the browser opens the page, then I use ^f to search for what I'm checking.) |
|
@mtbc ok to merge this size reduction PR? |
|
Okay to merge it. RFE to generate but not package it though because the report is useful: for example, just yesterday when I had set OMERO dependencies to 5.5.0-SNAPSHOT instead of the new 5.5.1-SNAPSHOT in testing ome/omero-server#51 |
|
If the report is still helpful, proposing to move these calls to a separate target that does not copy into the server bundles. Proposing |
|
All sounds good to me. (Don't mind if it's in default or not.) Fine if it all happens in some follow-up PR next month too. Cheers! |
|
Let's open an issue for the generation of report but not packaging of the report |
|
Issue created see #6038 |
With the recent work on OMERO 5.5, these files currently weigh 169M out of 480M for the complete server bundle. In addition to being extremely large, their size makes them almost non-usable.
Proposed changes
These generation of
dependencies.htmlusing the Ivy report tasks was introduced in 5a8db9c as part of the decoupling of Bio-Formats. For developers and especially for reviewing dependencies, having the dependency tree under some form and being able to review the version evictions still remains a useful resource. However, having it large HTML files as part of every bundle feels unnecessary.Testing
Without this PR, a build server (or the last 5.5.0 milestone) zip should be ~160MB or 480MB unzipped. With it included, the size should be largely reduced.