Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show fileset ID #385

Merged
merged 4 commits into from
Aug 6, 2022
Merged

Show fileset ID #385

merged 4 commits into from
Aug 6, 2022

Conversation

will-moore
Copy link
Member

See ome/omero-cli-zarr#123 (review)

It is useful for webclient users to see the Fileset ID for a selected Image.
We already load fileset info (file paths) in a file-paths info panel, so this seems a logical place to load and display fileset ID:

The tooltip for the button that launches this panel also mentions Fileset ID.

Screenshot 2022-07-22 at 12 04 40

@sbesson
Copy link
Member

sbesson commented Jul 29, 2022

Thanks, I am unaware of an alternate location in the web client which would expose Fileset information and would be more suitable.

Do we foresee adding more metadata about the fileset in the future? In this case, would it make sense to structure the top-level panel similarly to other elements i.e.

Fileset ID: <id>
Owner: <owner name>
File count: <count>

@sbesson sbesson requested a review from pwalczysko July 29, 2022 13:12
@will-moore
Copy link
Member Author

I don't think we need to show the Owner (can't imagine it's different from the Image owner very often) and the File count is already shown.

@pwalczysko
Copy link
Member

pwalczysko commented Aug 2, 2022

Works as expected with multi- and single-file filesets.
Maybe RFE would be to do one of the following:

  1. de-capitalize the word "Image" in the "Image file", see screenshot (because the capital image is not proper imho as well as it suggests that the important bit here is an "Image", whereas the number shows number of files
  2. Go partially for the suggestion of @sbesson in Show fileset ID #385 (comment) - I would also leave the "Owner" info out though, as it will add too much burden on the dialog unecessarily

I realize this is not a topic of this PR, but the whole header of the "Paths" dialog could do with some reformatting and unification of fonts, at the moment it looks like the features have been added randomly and without concern for what is there already - two boxes for the fileset info and "importer with ln_s" do not seem justified ?
Screenshot 2022-08-02 at 13 20 16

Copy link
Member

@pwalczysko pwalczysko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address #385 (comment)

@will-moore
Copy link
Member Author

Last commit looks like this:

Screenshot 2022-08-02 at 13 57 44

@pwalczysko
Copy link
Member

lgtm, thank you

@joshmoore joshmoore merged commit 8eabad0 into ome:master Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants