-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show fileset ID #385
Show fileset ID #385
Conversation
for more information, see https://pre-commit.ci
Thanks, I am unaware of an alternate location in the web client which would expose Fileset information and would be more suitable. Do we foresee adding more metadata about the fileset in the future? In this case, would it make sense to structure the top-level panel similarly to other elements i.e.
|
I don't think we need to show the Owner (can't imagine it's different from the Image owner very often) and the File count is already shown. |
Works as expected with multi- and single-file filesets.
I realize this is not a topic of this PR, but the whole header of the "Paths" dialog could do with some reformatting and unification of fonts, at the moment it looks like the features have been added randomly and without concern for what is there already - two boxes for the fileset info and "importer with ln_s" do not seem justified ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address #385 (comment)
lgtm, thank you |
See ome/omero-cli-zarr#123 (review)
It is useful for webclient users to see the Fileset ID for a selected Image.
We already load fileset info (file paths) in a file-paths info panel, so this seems a logical place to load and display fileset ID:
The tooltip for the button that launches this panel also mentions Fileset ID.