Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find upstream tag and Create tag #64

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

jburel
Copy link
Member

@jburel jburel commented Mar 16, 2022

This workflow is follow-up on #63 63
The workflow will run daily

  • If a new tag is found in ome/omero-web
  • A tag is created and pushed to this repository.
  • Then changes implemented in Push to dockerhub #63 will create and push to dockerhub
    The 2 workflows should then prevent the fact that the docker images have not been updated since 5.11.0

cc @sbesson @will-moore

@jburel jburel changed the title Find tag Find upstream tag and Create tag Mar 16, 2022
@joshmoore
Copy link
Member

Each time we create new workflow, I check the docs to see if it's possible to centralize them. https://docs.github.com/en/actions/using-workflows/reusing-workflows#creating-a-reusable-workflow is still unclear in that I think it must be in the same repo. https://stackoverflow.com/a/71166720/56887 is an interesting idea though to download it.

@sbesson
Copy link
Member

sbesson commented Mar 18, 2022

A few additional comments:

  • is the Makefile executed in the new workflow? If not I assume the images will lack commits similar to 8bf3614. As mentioned in Investigate labels creation to GitHub workflows omero-server-docker#57, I suspect it might be possible to move this logic into the deployment action
  • it looks like the new tag is never built before being pushed. This means potential failures should be handled via new tags?

@jburel
Copy link
Member Author

jburel commented Mar 18, 2022

  • for the Makefile point, i will need to investigate the labels.
  • For the tag step, we could add a step building the image before pushing.

@jburel
Copy link
Member Author

jburel commented Mar 18, 2022

Labels should be introduced in #63

@jburel
Copy link
Member Author

jburel commented Mar 23, 2022

After investigation this could be done fairly easily via a re-usable workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants