-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROI export with Well ID #173
Conversation
This saves us from storing all the data in-hand and writing all at once at the end
Co-authored-by: Mark Carroll <[email protected]>
Should we also omit the Points heading from |
Good to merge? |
I understand that was needed for the prototype. |
The amount of work to decide on a limit (which will depend on your setup as well as the number of columns in the table and the size of the Polygons you're exporting) is not worth it I think. The failure of this script when exporting large numbers of Polygons/Polylines is not new, and we haven't had anyone reporting problems. |
Another option is to export simplified Polygon to preserve the shape but without a long list of coordinates. |
Might be interesting to also use that as an opportunity to allow exporting WKT (https://shapely.readthedocs.io/en/latest/manual.html#well-known-formats) so we could begin building up familiarity with that. |
Trying to get some old PRs merged... |
The PR was approved prior to that discussion and was part of some work on a prototype. So it seems like a good opportunity to test |
The use of shapely is really unrelated to this PR (adding Well IDs). |
The points were previously included by default. To keep the same behaviour the |
Looks good to me. Tested on merge-ci, does what it says 👍 |
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: |
Re-listing for review again - trying to get some more PRs closed... |
When exporting ROIs to csv from SPW data, it is useful to include Well ID (and Well row, column and label).
This also adds the option to NOT export the Points coordinates string, which can cause a big increase in the size of the csv file.
This was needed for OMERO.parade prototype demo at https://youtu.be/FyjGhZxx6es?t=899
To test: