Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ref to ome channel for zeroc-ice #407

Merged
merged 3 commits into from
May 1, 2024

Conversation

jburel
Copy link
Member

@jburel jburel commented Apr 29, 2024

review instructions to use conda-forge channel

@pwalczysko
Copy link
Member

Could you please revise the sentence from the README

You may need to replace python3.8withpythonorpython3 depending on your Python distribution.

This does not seem either accurrate (3.8 has just been changed to 3.9) but maybe not even relevant ?

@pwalczysko
Copy link
Member

  1. the conda install works for both normal and developers.
  2. the venv install does not work, the pip install omero-py fails with as below (cannot build ice wheel)
      clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /Users/pwalczysko/mambaforge/include -fPIC -O2 -isystem /Users/pwalczysko/mambaforge/include -arch x86_64 -DICE_STATIC_LIBS -Isrc -Isrc/ice/cpp/include -Isrc/ice/cpp/src -I/Users/pwalczysko/Work/omero-py/testjmpy/include -I/Users/pwalczysko/mambaforge/include/python3.10 -c src/ice/cpp/src/Ice/WSEndpoint.cpp -o build/temp.macosx-11.0-arm64-cpython-310/src/ice/cpp/src/Ice/WSEndpoint.o -w
      clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /Users/pwalczysko/mambaforge/include -fPIC -O2 -isystem /Users/pwalczysko/mambaforge/include -arch x86_64 -DICE_STATIC_LIBS -Isrc -Isrc/ice/cpp/include -Isrc/ice/cpp/src -I/Users/pwalczysko/Work/omero-py/testjmpy/include -I/Users/pwalczysko/mambaforge/include/python3.10 -c src/ice/cpp/src/Ice/WSTransceiver.cpp -o build/temp.macosx-11.0-arm64-cpython-310/src/ice/cpp/src/Ice/WSTransceiver.o -w
      clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /Users/pwalczysko/mambaforge/include -fPIC -O2 -isystem /Users/pwalczysko/mambaforge/include -arch x86_64 -DICE_STATIC_LIBS -Isrc -Isrc/ice/cpp/include -Isrc/ice/cpp/src -I/Users/pwalczysko/Work/omero-py/testjmpy/include -I/Users/pwalczysko/mambaforge/include/python3.10 -c src/ice/cpp/src/IceDiscovery/IceDiscovery.cpp -o build/temp.macosx-11.0-arm64-cpython-310/src/ice/cpp/src/IceDiscovery/IceDiscovery.o -w
      clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /Users/pwalczysko/mambaforge/include -fPIC -O2 -isystem /Users/pwalczysko/mambaforge/include -arch x86_64 -DICE_STATIC_LIBS -Isrc -Isrc/ice/cpp/include -Isrc/ice/cpp/src -I/Users/pwalczysko/Work/omero-py/testjmpy/include -I/Users/pwalczysko/mambaforge/include/python3.10 -c src/ice/cpp/src/IceDiscovery/LocatorI.cpp -o build/temp.macosx-11.0-arm64-cpython-310/src/ice/cpp/src/IceDiscovery/LocatorI.o -w
      clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /Users/pwalczysko/mambaforge/include -fPIC -O2 -isystem /Users/pwalczysko/mambaforge/include -arch x86_64 -DICE_STATIC_LIBS -Isrc -Isrc/ice/cpp/include -Isrc/ice/cpp/src -I/Users/pwalczysko/Work/omero-py/testjmpy/include -I/Users/pwalczysko/mambaforge/include/python3.10 -c src/ice/cpp/src/IceDiscovery/LookupI.cpp -o build/temp.macosx-11.0-arm64-cpython-310/src/ice/cpp/src/IceDiscovery/LookupI.o -w
      clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /Users/pwalczysko/mambaforge/include -fPIC -O2 -isystem /Users/pwalczysko/mambaforge/include -arch x86_64 -DICE_STATIC_LIBS -Isrc -Isrc/ice/cpp/include -Isrc/ice/cpp/src -I/Users/pwalczysko/Work/omero-py/testjmpy/include -I/Users/pwalczysko/mambaforge/include/python3.10 -c src/ice/cpp/src/IceDiscovery/PluginI.cpp -o build/temp.macosx-11.0-arm64-cpython-310/src/ice/cpp/src/IceDiscovery/PluginI.o -w
      clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /Users/pwalczysko/mambaforge/include -fPIC -O2 -isystem /Users/pwalczysko/mambaforge/include -arch x86_64 -DICE_STATIC_LIBS -Isrc -Isrc/ice/cpp/include -Isrc/ice/cpp/src -I/Users/pwalczysko/Work/omero-py/testjmpy/include -I/Users/pwalczysko/mambaforge/include/python3.10 -c src/ice/cpp/src/IceLocatorDiscovery/IceLocatorDiscovery.cpp -o build/temp.macosx-11.0-arm64-cpython-310/src/ice/cpp/src/IceLocatorDiscovery/IceLocatorDiscovery.o -w
      clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /Users/pwalczysko/mambaforge/include -fPIC -O2 -isystem /Users/pwalczysko/mambaforge/include -arch x86_64 -DICE_STATIC_LIBS -Isrc -Isrc/ice/cpp/include -Isrc/ice/cpp/src -I/Users/pwalczysko/Work/omero-py/testjmpy/include -I/Users/pwalczysko/mambaforge/include/python3.10 -c src/ice/cpp/src/IceLocatorDiscovery/PluginI.cpp -o build/temp.macosx-11.0-arm64-cpython-310/src/ice/cpp/src/IceLocatorDiscovery/PluginI.o -w
      clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /Users/pwalczysko/mambaforge/include -fPIC -O2 -isystem /Users/pwalczysko/mambaforge/include -arch x86_64 -DICE_STATIC_LIBS -Isrc -Isrc/ice/cpp/include -Isrc/ice/cpp/src -I/Users/pwalczysko/Work/omero-py/testjmpy/include -I/Users/pwalczysko/mambaforge/include/python3.10 -c src/ice/cpp/src/IceSSL/AcceptorI.cpp -o build/temp.macosx-11.0-arm64-cpython-310/src/ice/cpp/src/IceSSL/AcceptorI.o -w
      In file included from src/ice/cpp/src/IceSSL/AcceptorI.cpp:14:
      In file included from src/ice/cpp/src/IceSSL/OpenSSLTransceiverI.h:14:
      In file included from src/ice/cpp/src/IceSSL/Util.h:23:
      In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/Security.h:27:
      /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecBase.h:88:33: error: typedef redefinition with different types ('struct __SecCertificate' vs 'OpaqueSecCertificateRef')
      typedef struct __SecCertificate OpaqueSecCertificateRef;
                                      ^
      src/ice/cpp/include/IceSSL/Plugin.h:67:8: note: previous definition is here
      struct OpaqueSecCertificateRef;
             ^
      In file included from src/ice/cpp/src/IceSSL/AcceptorI.cpp:14:
      In file included from src/ice/cpp/src/IceSSL/OpenSSLTransceiverI.h:14:
      In file included from src/ice/cpp/src/IceSSL/Util.h:23:
      In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/Security.h:27:
      /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecBase.h:111:25: error: typedef redefinition with different types ('struct __SecKey' vs 'OpaqueSecKeyRef')
      typedef struct __SecKey OpaqueSecKeyRef;
                              ^
      src/ice/cpp/include/IceSSL/Plugin.h:73:8: note: previous definition is here
      struct OpaqueSecKeyRef;
             ^
      2 errors generated.
      error: command '/usr/bin/clang' failed with exit code 1
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for zeroc-ice
Failed to build zeroc-ice
ERROR: Could not build wheels for zeroc-ice, which is required to install pyproject.toml-based projects

Copy link
Member

@pwalczysko pwalczysko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

venv install does not seem to work #407 (comment)

@jburel
Copy link
Member Author

jburel commented Apr 29, 2024

@pwalczysko That's why I put the comment about installing the Ice-Python binding and see tox.ini file as an example
this really depends on the OS and Python version. You are trying to build it from source which as we know does not work in many cases.

This is not suitable for the README since we have far too many cases to handle

@jburel jburel merged commit 53a327b into ome:master May 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants