update the build steps #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbesson
reviewed
Apr 19, 2024
There was a problem hiding this comment.
The changes are hard to test as they are only executed on release. The usage of the new build target is identical to https://github.com/ome/omero-scripts/actions/runs/8740926594 where similar changes were made and the last release was successful.
One question about the action bump which was not done in omero-scripts
| - name: Publish to PyPI | ||
| uses: pypa/gh-action-pypi-publish@v1.3.0 | ||
| uses: pypa/gh-action-pypi-publish@v1.8.14 |
There was a problem hiding this comment.
Is this a requirement for the workflow/repository? Or just a regular maintenance upgrade?
sbesson
approved these changes
Apr 19, 2024
This was referenced Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the way the packages are built on merge-ci. This is now the recommended way